Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .github/workflows/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,31 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4

- name: Use Node.js
uses: actions/setup-node@v3
with:
node-version: 20
Comment on lines 17 to 19
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Update actions/setup-node to v4.

actions/setup-node@v3 is outdated and no longer actively maintained. Update to the latest version for improved compatibility, security patches, and performance.

Apply this diff:

  - name: Use Node.js
-   uses: actions/setup-node@v3
+   uses: actions/setup-node@v4
    with:
        node-version: 20
🧰 Tools
🪛 actionlint (1.7.8)

17-17: the runner of "actions/setup-node@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)

🤖 Prompt for AI Agents
In .github/workflows/e2e.yml around lines 17 to 19, update the GitHub Action
setup step to use the newer actions/setup-node@v4 instead of
actions/setup-node@v3; edit the workflow to change the action reference to
actions/setup-node@v4 while keeping the existing with: node-version: 20
configuration so the runner uses Node 20 with the maintained v4 action.


- name: Install pnpm
uses: pnpm/action-setup@v4

- name: Install dependencies
run: pnpm install --frozen-lockfile

- name: Cache Playwright browsers
uses: actions/cache@v4
id: playwright-cache
with:
path: ~/.cache/ms-playwright
key: ${{ runner.os }}-playwright-${{ hashFiles('**/pnpm-lock.yaml') }}
restore-keys: |
${{ runner.os }}-playwright-

- name: Install Playwright Browsers
if: steps.playwright-cache.outputs.cache-hit != 'true'
run: pnpm exec playwright install --with-deps chromium

- name: E2E Tests
run: pnpm run e2e
- uses: actions/upload-artifact@v4
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,21 +15,29 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4

- name: Use Node.js
uses: actions/setup-node@v3
with:
node-version: 20
Comment on lines 20 to 22
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Update actions/setup-node to v4.

actions/setup-node@v3 is outdated and no longer actively maintained. Update to the latest version for improved compatibility, security patches, and performance.

Apply this diff:

  - name: Use Node.js
-   uses: actions/setup-node@v3
+   uses: actions/setup-node@v4
    with:
        node-version: 20
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
uses: actions/setup-node@v3
with:
node-version: 20
uses: actions/setup-node@v4
with:
node-version: 20
🧰 Tools
🪛 actionlint (1.7.8)

20-20: the runner of "actions/setup-node@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)

🤖 Prompt for AI Agents
.github/workflows/tests.yml around lines 20 to 22: the workflow pins
actions/setup-node@v3 which is outdated; update the action reference to the
latest major (v4) by changing the uses entry to actions/setup-node@v4 so the
workflow uses the maintained version; ensure no other config keys break with v4
and run the workflow to verify node setup still works.


- name: Install pnpm
uses: pnpm/action-setup@v4

- name: Audit dependencies
run: pnpm audit --audit-level high

- name: Install dependencies
run: pnpm install --frozen-lockfile

- name: Svelte Diagnostics
run: pnpm run check

- name: Linter
run: pnpm run lint

- name: Unit Tests
run: pnpm run test

- name: Build Console
run: pnpm run build