Skip to content

Refactor: change create file from modal to wizard #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ArmanNik merged 14 commits into from
Dec 12, 2023
Merged

Refactor: change create file from modal to wizard #313

ArmanNik merged 14 commits into from
Dec 12, 2023

Conversation

@TGlide
Copy link
Contributor

@TGlide TGlide commented Feb 20, 2023

What does this PR do?

Changes Create File from modal to a wizard

Test Plan

Manual

Related PRs and Issues

N/a

Have you read the Contributing Guidelines on issues?

Yes

@TGlide TGlide added the enhancement New feature or request label Feb 20, 2023
@TGlide TGlide self-assigned this Feb 20, 2023
@vercel
Copy link

vercel bot commented Feb 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
console ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2023 0:02am
console-1-3-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2023 0:02am
console-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2023 0:02am
console-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2023 0:02am
console-preview-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2023 0:02am

@eldadfux
Copy link
Member

eldadfux commented Mar 4, 2023 •
edited by gewenyu99
Loading

@TGlide title should be Create file not Upload file. @gewenyu99 I think all the wizard steps should use labels / nouns to describe the steps instead of using verbs / actions. Does this align with our UX writing?
image

🤔 Yeah, we don't have to write full sentences for these things. Why write more when fewer words do trick insert Patrick star impression.

@gewenyu99
Copy link

gewenyu99 commented Mar 9, 2023

Sorry I edited Eldad's message by accident.

🤔 Yeah, we don't have to write full sentences for these things. Why write more when fewer words do trick insert Patrick star impression.

@TGlide
Copy link
Contributor Author

TGlide commented Mar 9, 2023 •
edited
Loading

Sorry I edited Eldad's message by accident.

🤔 Yeah, we don't have to write full sentences for these things. Why write more when fewer words do trick insert Patrick star impression.

@heyCarla @chenparnasa should we edit the overall copy here then?

@heyCarla
Copy link
Contributor

heyCarla commented Mar 16, 2023

@heyCarla @chenparnasa should we edit the overall copy here then?

To be clear -- we should be using the copy, Create file for the following:

  • the wizard title in the nav bar
  • the first wizard step
  • the content/right side title for the first step

Is that correct, @eldadfux @gewenyu99?

ArmanNik
ArmanNik reviewed Mar 16, 2023
View reviewed changes
src/lib/layout/wizardStep.svelte
Comment on lines +28 to +33
<style>
.hide-divider {
padding-block-end: 0;
border-block-end: none;
}
</style>
Copy link
Contributor

@ArmanNik ArmanNik Mar 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add this in pink? @elad2412

@gewenyu99
Copy link

gewenyu99 commented Mar 20, 2023

@heyCarla @chenparnasa should we edit the overall copy here then?

To be clear -- we should be using the copy, Create file for the following:

  • the wizard title in the nav bar
  • the first wizard step
  • the content/right side title for the first step

Is that correct, @eldadfux @gewenyu99?

Yep :)

@TGlide TGlide requested a review from ArmanNik April 17, 2023 11:06
@TGlide
Copy link
Contributor Author

TGlide commented Apr 17, 2023

Changed copy to create file

@stnguyen90 stnguyen90 marked this pull request as draft October 5, 2023 17:31
@stnguyen90
Copy link
Contributor

stnguyen90 commented Oct 5, 2023

Converting to draft due to merge conflicts.

@gewenyu99
Copy link

gewenyu99 commented Oct 6, 2023 •
edited
Loading

Holy gosh
this is old.

@ArmanNik ArmanNik changed the base branch from main to billing December 12, 2023 11:56
@ArmanNik ArmanNik marked this pull request as ready for review December 12, 2023 11:59
@ArmanNik ArmanNik merged commit 9ec2f21 into billing Dec 12, 2023
@ArmanNik ArmanNik deleted the refactor/create-file-wizard branch December 12, 2023 12:00
@github-actions github-actions bot mentioned this pull request Jan 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TorstenDittmann TorstenDittmann Awaiting requested review from TorstenDittmann

2 more reviewers

@heyCarla heyCarla heyCarla left review comments

@ArmanNik ArmanNik ArmanNik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TGlide TGlide

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@TGlide @eldadfux @gewenyu99 @heyCarla @stnguyen90 @ArmanNik @TorstenDittmann