From e30fe1fa7c1b9bc2439db0e0b5e2b001b15eeaf2 Mon Sep 17 00:00:00 2001 From: Steven Nguyen Date: Thu, 22 Feb 2024 12:39:40 -0800 Subject: [PATCH 1/2] chore(components): fix lint error --- src/lib/elements/forms/inputDate.svelte | 2 +- src/lib/elements/forms/inputTime.svelte | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lib/elements/forms/inputDate.svelte b/src/lib/elements/forms/inputDate.svelte index 11816ea73f..95cd6813cf 100644 --- a/src/lib/elements/forms/inputDate.svelte +++ b/src/lib/elements/forms/inputDate.svelte @@ -71,7 +71,7 @@ {max} autocomplete={autocomplete ? 'on' : 'off'} type="date" - style={disabled ? "" : "cursor: pointer;"} + style={disabled ? '' : 'cursor: pointer;'} class="input-text" bind:value bind:this={element} diff --git a/src/lib/elements/forms/inputTime.svelte b/src/lib/elements/forms/inputTime.svelte index 499b9d7438..2e0caf60bf 100644 --- a/src/lib/elements/forms/inputTime.svelte +++ b/src/lib/elements/forms/inputTime.svelte @@ -57,7 +57,7 @@ autocomplete={autocomplete ? 'on' : 'off'} type="time" class="input-text" - style={disabled ? "" : "cursor: pointer;"} + style={disabled ? '' : 'cursor: pointer;'} bind:value bind:this={element} on:invalid={handleInvalid} From f50d6c473b6d903bfca9ad7a9dcb46b235a691de Mon Sep 17 00:00:00 2001 From: Steven Nguyen Date: Thu, 22 Feb 2024 12:56:02 -0800 Subject: [PATCH 2/2] fix(messaging): prevent duplicate create subscriber calls Update subscribersByTargetId with created subscribers so subsequent addTarget() calls won't add the same targets again. --- .../topics/topic-[topic]/subscribers/+page.svelte | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/routes/console/project-[project]/messaging/topics/topic-[topic]/subscribers/+page.svelte b/src/routes/console/project-[project]/messaging/topics/topic-[topic]/subscribers/+page.svelte index 08d6fd58a8..c5c308a5e6 100644 --- a/src/routes/console/project-[project]/messaging/topics/topic-[topic]/subscribers/+page.svelte +++ b/src/routes/console/project-[project]/messaging/topics/topic-[topic]/subscribers/+page.svelte @@ -46,9 +46,14 @@ const targetIds = Object.keys($targetsById).filter( (targetId) => !(targetId in subscribersByTargetId) ); - const promises = targetIds.map((targetId) => - sdk.forProject.messaging.createSubscriber($page.params.topic, ID.unique(), targetId) - ); + const promises = targetIds.map(async (targetId) => { + const subscriber = await sdk.forProject.messaging.createSubscriber( + $page.params.topic, + ID.unique(), + targetId + ); + subscribersByTargetId[targetId] = subscriber; + }); try { await Promise.all(promises);