Feat dart test exception #138
Conversation
tests/SDKTest.php
Outdated
| $this->assertEquals('GET:/v1/mock/tests/general/redirect/done:passed', $output[10]); | ||
|
|
||
| if($options['supportUpload']) { | ||
| $supportsUpload = $options['supportUpload']; |
There was a problem hiding this comment.
Unless we don't use this var in other places, I think we can keep it they way it was.
tests/SDKTest.php
Outdated
| $this->assertEquals($output[11], 'POST:/v1/mock/tests/general/upload:passed'); | ||
| } | ||
|
|
||
| if($options['supportException']) { |
There was a problem hiding this comment.
Maybe we can leave blank lines reserved for the upload test or even a comment in the code, otherwise every new feature here is going to get a really big block of if conditions.
There was a problem hiding this comment.
yes we need a way, may be simply print some value ('upload not supported yet') to make the outputs length and index consistent, so that we don't need multiple checks, let me know what you think?
tests/SDKTest.php
Outdated
|
|
||
| $whitelist = ['php', 'cli', 'java', 'node', 'ruby', 'python', 'typescript', 'deno', 'dotnet', 'dart']; | ||
|
|
||
| $whitelist = ['dart']; |
There was a problem hiding this comment.
Reminder to remove this from the PR
|
@eldadfux Looks like Java SDK doesn't support UPLOAD yet |
|
@eldadfux even typescript SDK did not have upload support, I just printed the actual output of upload success to pass the typescript test. Apart from that Dart exception test is ✅ |
|
Looks good! |
No description provided.