Skip to content

Conversation

@TorstenDittmann
Copy link
Contributor

  • add param checking

before:

def update_document(collection_id:, document_id:, data:, read: [], write: [])
    path = '/database/collections/{collectionId}/documents/{documentId}'
        .gsub('{collectionId}', collection_id)
        .gsub('{documentId}', document_id)

    params = {
        'data': data, 
        'read': read, 
        'write': write
    }

    return @client.call('patch', path, {
        'content-type' => 'application/json',
    }, params);
end

after:

def update_document(collection_id, document_id, data, read = nil, write = nil)
    if collection_id.nil?
        raise Appwrite::Exception.new('Missing required parameter: "collectionId"')
    end

    if document_id.nil?
        raise Appwrite::Exception.new('Missing required parameter: "documentId"')
    end

    if data.nil?
        raise Appwrite::Exception.new('Missing required parameter: "data"')
    end

    path = '/database/collections/{collectionId}/documents/{documentId}'
        .gsub('{collectionId}', collection_id)
        .gsub('{documentId}', document_id)

    params = {}

    if !execute.nil?
        params[:data] = data
    end

    if !execute.nil?
        params[:read] = read
    end

    if !execute.nil?
        params[:write] = write
    end

    return @client.call('patch', path, {
        'content-type' => 'application/json',
    }, params);
end

@TorstenDittmann TorstenDittmann marked this pull request as ready for review June 2, 2021 09:28
@eldadfux eldadfux merged commit fc60f3e into master Jun 2, 2021
@lohanidamodar lohanidamodar deleted the fix-ruby-overall-improvements branch June 5, 2022 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants