Skip to content

Conversation

@kutear
Copy link
Contributor

@kutear kutear commented Jun 23, 2021

Historically, HTTP has allowed field content with text in the
ISO-8859-1 charset [ISO-8859-1], supporting other charsets only
through use of [RFC2047] encoding. In practice, most HTTP header
field values use only a subset of the US-ASCII charset [USASCII].
Newly defined header fields SHOULD limit their field values to
US-ASCII octets. A recipient SHOULD treat other octets in field
content (obs-text) as opaque data.

But appName may be contain non-ASCII char. so replace with package

ref: appwrite/sdk-for-flutter#25

@kutear kutear changed the title fixed: non-ASCII char in http header fixed: non-ASCII char in request header Jun 23, 2021
@eldadfux eldadfux requested a review from lohanidamodar June 23, 2021 17:20
Copy link
Member

@lohanidamodar lohanidamodar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems logical. Thank you for your PR

@lohanidamodar
Copy link
Member

@kutear can you please sync with latest master so that we can see the tests passing. Thank you 🙏🏻

@kutear
Copy link
Contributor Author

kutear commented Jun 29, 2021

@kutear can you please sync with latest master so that we can see the tests passing. Thank you 🙏🏻

I had merge master and ci was passed.

@eldadfux eldadfux merged commit 9dd1321 into appwrite:master Jun 30, 2021
@eldadfux
Copy link
Member

Thanks @kutear !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants