Feat android/kotlin realtime #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xtension constructs
…callback registration, socket close looping
abnegate
requested review from
TorstenDittmann,
christyjacob4,
eldadfux and
lohanidamodar
Contributor
TorstenDittmann
left a comment
TorstenDittmann
left a comment
There was a problem hiding this comment.
Can't really say much about the kotlin part - except that you've done a great job as it looks like 😄
templates/android/library/src/main/java/io/appwrite/services/Realtime.kt.twig
Show resolved
Hide resolved
templates/android/library/src/main/java/io/appwrite/services/Realtime.kt.twig
Outdated
Show resolved
Hide resolved
templates/android/library/src/main/java/io/appwrite/services/Realtime.kt.twig
Outdated
Show resolved
Hide resolved
christyjacob4
requested changes
Aug 23, 2021
Contributor
christyjacob4
left a comment
christyjacob4
left a comment
There was a problem hiding this comment.
Added a few comments. Rest looks great 🚀 Awesome work @abnegate
christyjacob4
approved these changes
Aug 23, 2021
Contributor
christyjacob4
left a comment
christyjacob4
left a comment
There was a problem hiding this comment.
Looks good @abnegate 👍
lohanidamodar
approved these changes
Aug 24, 2021
templates/android/library/src/main/java/io/appwrite/models/RealtimeError.kt.twig
Outdated
Show resolved
Hide resolved
templates/android/library/src/main/java/io/appwrite/models/RealtimeEvent.kt.twig
Outdated
Show resolved
Hide resolved
templates/android/library/src/main/java/io/appwrite/services/Realtime.kt.twig
Show resolved
Hide resolved
templates/android/library/src/main/java/io/appwrite/Client.kt.twig
Outdated
Show resolved
Hide resolved
TorstenDittmann
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.