-
Notifications
You must be signed in to change notification settings - Fork 293
fix: add PowerShell script back to website #2642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: add PowerShell script back to website #2642
Conversation
WalkthroughA new server-side route handler file is created at Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/routes/cli/install.ps1/+page.server.ts(1 hunks)
🔇 Additional comments (1)
src/routes/cli/install.ps1/+page.server.ts (1)
3-5: The code is correct as written and does not require modification.SvelteKit v2+ changed the
redirect()function behavior: it now throws automatically without requiring an explicitthrowkeyword. The current implementationredirect(301, 'https://raw.githubusercontent.com/appwrite/sdk-for-cli/refs/heads/master/install.ps1')will work correctly. Addingthrowbefore it would be incorrect for SvelteKit v2+.Likely an incorrect or invalid review comment.
|
heyy @M4dhav, thanks for your contribution. can you run |
After running |
|
Hey @HarshMN2345 @ChiragAgg5k I noticed that tests were failing on my PR so I tried to investigate it but it looks like build is failing on the main branch as well, but tests are running on my local. How do you want me to proceed? |
I think builds on my local might be failing due to sentry not being setup |
…641-add-windows-cli-install-script-back
|
Hey @HarshMN2345 I investigated the tests further, as they were running locally. I ran the tests job on my fork and they passed, where the only difference is environment variables. Were the vars changed recently? If so, they might be causing the workflow runs to fail |
What does this PR do?
This PR adds the Powershell script back to the site after it was removed by some previous PR
Test Plan
Run the website and go to /cli/install.ps1
Related PRs and Issues
fixes #2641
Have you read the Contributing Guidelines on issues?
Yes
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.