Cleanup foodcritic warnings #44

Closed
yourabi opened this Issue Dec 5, 2013 · 7 comments

Projects

None yet

2 participants

@yourabi
Collaborator
yourabi commented Dec 5, 2013

foodcritic -f any -B .

FC002: Avoid string interpolation where not required: ./templates/default/monitrc.erb:37
FC012: Use Markdown for README rather than RDoc: ./README.rdoc:1
FC015: Consider converting definition to a LWRP: ./definitions/monitrc.rb:1
FC019: Access node attributes in a consistent manner: ./attributes/default.rb:9
FC023: Prefer conditional attributes: ./recipes/default.rb:3
FC027: Resource sets internal attribute: ./recipes/default.rb:28
FC043: Prefer new notification syntax: ./definitions/monitrc.rb:6
FC043: Prefer new notification syntax: ./definitions/monitrc.rb:9
FC043: Prefer new notification syntax: ./definitions/monitrc.rb:20

@jwmarshall
Contributor

I have a feature branch that fixes most these, look at feature/please-the-foodcritic

@yourabi
Collaborator
yourabi commented Dec 5, 2013

Cool. I've made a few of those fixes already but looks like duplicate work so I'll blow away my changes and let you merge yours in.

You might want to consider future feature branches in your own fork instead of against the main-repo so that we can use of PRs.

@yourabi
Collaborator
yourabi commented Dec 5, 2013

BTW - forgot to add. let me know if you want to split up the work of tackling these. Happy to help out with this and will be good to get food critic happy again :-)

@jwmarshall
Contributor

Pretty sure I can still do a PR off the same repository, but I will create a fork for future work. I think my branch is complete, just didn't want to PR and merge right before going to bed.

@yourabi
Collaborator
yourabi commented Dec 5, 2013

Cool - and wise choice!

@yourabi
Collaborator
yourabi commented Dec 20, 2013

Hey - how is this going?

Please let me know if you want to divide up the work.

I'd like to merge in some fixes and start chatting about cutting a release and would be good to have this squared away.

@yourabi
Collaborator
yourabi commented Sep 10, 2014

Since this has gone stale closing as duplicate of newer #58

@yourabi yourabi closed this Sep 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment