New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional configuration options as Chef attributes #3

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
@organicveggie
Contributor

organicveggie commented Mar 22, 2012

This extracts a bunch of the configuration options in monitrc into Chef attributes that can be overridden.

@apsoto

This comment has been minimized.

Show comment
Hide comment
@apsoto

apsoto Mar 22, 2012

Owner

Re-adding my comments to the pull request:

line 23 of monitrc.erb looks like it doesn't have a closing %> for the port, line 27 has a > instead of a ? after the .nil check.

Can you verify these changes work (You've deployed it to a server?) and re-submit.

also could you switch to the new style of attribute reference (Ex: node.httpd.enable)

thanks

Owner

apsoto commented Mar 22, 2012

Re-adding my comments to the pull request:

line 23 of monitrc.erb looks like it doesn't have a closing %> for the port, line 27 has a > instead of a ? after the .nil check.

Can you verify these changes work (You've deployed it to a server?) and re-submit.

also could you switch to the new style of attribute reference (Ex: node.httpd.enable)

thanks

@apsoto apsoto closed this Mar 22, 2012

@organicveggie

This comment has been minimized.

Show comment
Hide comment
@organicveggie

organicveggie Mar 22, 2012

Contributor

Story of my life. My cookbook repository has a submodule for monit that was pointing at your repo, instead of mine. No wonder it worked on the first try. :)

I'll resubmit when it's ready.

Contributor

organicveggie commented Mar 22, 2012

Story of my life. My cookbook repository has a submodule for monit that was pointing at your repo, instead of mine. No wonder it worked on the first try. :)

I'll resubmit when it's ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment