Add recipes for monitoring resque workers and a scheduler #30

Merged
merged 1 commit into from Sep 20, 2014

Conversation

Projects
None yet
3 participants
Contributor

anujbiyani commented May 21, 2013

Based on what you said here it sounds like adding recipes for monitoring specific packages is something you'd rather avoid, but you're open to discussing it.

I think it's a good idea to support recipes like this for a couple reasons:

  1. Allows the end-user to keep their monit stuff in a monit cookbook. If I want to use the monitrc definition, I have to write a recipe in my own cookbook that calls the definition and maybe supplies a template file. Then in the future if I ever change from monit to some other monitoring service, I have to remove code from multiple locations.
  2. These recipes are sometimes useful to other people. In this specific case (resque), it's not rare for a Rails app to be using resque and monit; it'd be nice to also provide them with sane defaults.
  3. Reduces the number of forks so that there's one canonical repo for all things monit.

On the flip side:

  1. The burden of maintaining these recipes falls on you instead of on a fork or in a private repository.
  2. This cookbook could grow to be quite large if a lot of different recipes are added.
Owner

apsoto commented Oct 21, 2013

Hey, are you willing to take on maintainer responsibilities? My time is severely limited and don't have the bandwidth to test changes?

Contributor

anujbiyani commented Oct 31, 2013

Sorry I don't think I have enough time either, but it seems like you found maintainers!

Contributor

anujbiyani commented Mar 24, 2014

Rebased on master.

Contributor

anujbiyani commented Sep 10, 2014

Freshly rebased on master.

Collaborator

yourabi commented Sep 12, 2014

Hi - could you please cleanup the foodcritic warnings...

Thanks!

Contributor

anujbiyani commented Sep 12, 2014

Fixed! Hopefully Travis agrees =)

@yourabi yourabi closed this Sep 20, 2014

@yourabi yourabi reopened this Sep 20, 2014

yourabi added a commit that referenced this pull request Sep 20, 2014

Merge pull request #30 from Lytro/resque
Add recipes for monitoring resque workers and a scheduler

@yourabi yourabi merged commit d290631 into apsoto:master Sep 20, 2014

1 check was pending

continuous-integration/travis-ci The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment