Switch from library to definition #4
Merged
Conversation
I recall that the initial 'immediate' reload after laying down the monitrc was due to some issues I encountered when doing an initial run and later in the run something tried to do something with monit service and the service returning a non zero exit code and failing the run because it hadn't been initialized. Can't remember the details now, so I won't worry about it. Your changes look good, thanks for the cleanup |
apsoto
added a commit
that referenced
this pull request
Apr 8, 2012
Switch from library to definition
anujbiyani
pushed a commit
to Lytro/monit
that referenced
this pull request
Jan 29, 2013
Switch from library to definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Definitions are usually the preferred method in Chef for creating new resources. Libraries are more typically used to include arbitrary ruby code that extends Chef itself. These commits switch from a library to a definition along the same lines as the official Opscode apache2 cookbook.