New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from library to definition #4

Merged
merged 2 commits into from Apr 8, 2012

Conversation

Projects
None yet
2 participants
@organicveggie
Contributor

organicveggie commented Mar 22, 2012

Definitions are usually the preferred method in Chef for creating new resources. Libraries are more typically used to include arbitrary ruby code that extends Chef itself. These commits switch from a library to a definition along the same lines as the official Opscode apache2 cookbook.

@apsoto

This comment has been minimized.

Show comment
Hide comment
@apsoto

apsoto Mar 22, 2012

Owner

I recall that the initial 'immediate' reload after laying down the monitrc was due to some issues I encountered when doing an initial run and later in the run something tried to do something with monit service and the service returning a non zero exit code and failing the run because it hadn't been initialized. Can't remember the details now, so I won't worry about it.

Your changes look good, thanks for the cleanup

Owner

apsoto commented Mar 22, 2012

I recall that the initial 'immediate' reload after laying down the monitrc was due to some issues I encountered when doing an initial run and later in the run something tried to do something with monit service and the service returning a non zero exit code and failing the run because it hadn't been initialized. Can't remember the details now, so I won't worry about it.

Your changes look good, thanks for the cleanup

apsoto added a commit that referenced this pull request Apr 8, 2012

Merge pull request #4 from StudyBlue/definition
Switch from library to definition

@apsoto apsoto merged commit 93b7314 into apsoto:master Apr 8, 2012

anujbiyani pushed a commit to Lytro/monit that referenced this pull request Jan 29, 2013

Merge pull request #4 from StudyBlue/definition
Switch from library to definition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment