Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Multi platform #5

Open
wants to merge 1 commit into from

5 participants

@gilles

Hi,

I have updated the cookbook to be multi platform, I also updated the monitrc files to look like the packaged one.

I've also made a comment in the definition to namespace the source file path. The version I use here is of the form "monit/#{name}.conf.erb".

Thanks for considering

--Gilles

@gilles gilles multi platform.
monitrc is also updated to look like the packaged one
996e92c
@apsoto
Owner

hey there, sorry for the delay, currently working on merging things (unfortunately it's not going in clean)

I have a question, can you explain what you mean by the comment in libraries/monitrc.rb:

#this should be "monit/#{name}.conf.erb" or "#{name}.monit.conf.erb" to not conflict with other conf files

I'm unclear on the "monit/#{name}.conf.erb" part. Does that mean it would look for the template inside the monit cookbook templates dir with a name of "#{name}.conf.erb"?

@gilles

Hi,

I mean that monit configuration files for services should be in the local cookbook but in a 'monit/' subdirectory, in 'templates/default/monit/' to be precise.

For example on debian memcache uses a memcache.conf. Meaning the template is 'templates/default/memcache.conf.erb.'

If I want to create a monit check I have to name it 'templates/default/memcache.monit.conf.erb' and the target file name will be memcache.monit.conf

I think having the monit template as 'templates/default/monit/memcache.conf.erb' is cleaner.

I do the same for ganglia, all my ganglia plugins are in templates/default/ganglia, same for nagios nrpe, etc. I find my cookbooks more maintainable in the long run.

Thanks

@apsoto
Owner

As I'm merging I'm noticing that things are not going to stay backwards compatible anyway since I also merged in a patch that moves the LWRP from a library to a definition.

Therefore, I'll try to adopt the subdir convention as the next release will break backwards compatibility anyway.

@freerobby
Collaborator

@apsoto Do we want to start a new branch for the next release that will not provide backwards compatibility? I'm not sure what to do with PRs like this at this point.

@apsoto
Owner

good idea, go for it.

If you can release a version that's still backwards compatible, I say release it as 1.0, then next one can be 2.0.

If you have time, create 1.X and 2.X series branches.

Thanks

@ryansch

:+1:

I just started implementing this myself only to discover this pull request. This cookbook doesn't work correctly on redhat family distros when running on master.

@apsoto
Owner

I'm strapped for time, if anyone wants to step up and handle this I can add as a collaborator.

@yourabi
Collaborator

I think this would be a good addition.

@gilles - if you're still interested can you rebase this against the recent changes and I'll help merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 28, 2012
  1. @gilles

    multi platform.

    gilles authored
    monitrc is also updated to look like the packaged one
Something went wrong with that request. Please try again.