Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1312.
Aptly has a bug in its dependency resolution where certain dependencies do not get added even if they are not satisfied.
Steps to reproduce (tested with latest
master
):The package
python-pep517
depends onpython3-tomli
:But Aptly does not include
python3-tomli
in the mirror.This is because
black
includes the following dependency:python3-tomli | python3 (>> 3.11)
.This dependency is satisfied by including
python3
, but as a side effect of evaluating this dependency, Aptly includespython3-tomli
in thecache
inVerifyDependencies
.The bug is that this causes
python3-tomli
to be excluded, even though its cache entry isfalse
(i.e., not satisfied).Requirements
All new code should be covered with tests, documentation should be updated. CI should pass.
Description of the Change
This was causing issues for us because Aptly did not download all dependencies even with
-filter-with-deps
.I fixed this bug by just checking for the
satisfied
status instead of also requiring that the dependency not be included in the cache.Checklist
AUTHORS