New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Merge snapshots by latest package versions #42

Merged
merged 16 commits into from Apr 23, 2014

Conversation

Projects
None yet
3 participants
@ryanuber
Copy link
Contributor

ryanuber commented Apr 23, 2014

Hey @smira!
This patch adds the ability to merge mirror snapshots with the latest version of each package (fixes #38). The command switch I used is aptly snapshot merge -latest .... If the -latest flag is not provided, functionality is unchanged.

The FilterLatestRefs function should be reusable in case we need to do latest package filtering elsewhere at some point.

I looked for a place to update the aptly.info source but didn't find it, let me know if I am missing it somewhere and I'll be happy to update that as well.

Let me know what you think. Thanks!

@smira smira added this to the v0.5 milestone Apr 23, 2014

@smira smira added the enhancement label Apr 23, 2014

@smira smira merged commit 3800f2c into aptly-dev:master Apr 23, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

smira added a commit that referenced this pull request Apr 23, 2014

Move command description from man file to command help. #42
Man file is auto-generated from inline command help.

N.B. I should document this in Contributing.

smira added a commit that referenced this pull request Apr 23, 2014

smira added a commit that referenced this pull request Apr 23, 2014

smira added a commit that referenced this pull request Apr 23, 2014

smira added a commit that referenced this pull request Apr 23, 2014

smira added a commit that referenced this pull request Apr 23, 2014

@smira

This comment has been minimized.

Copy link
Member

smira commented Apr 23, 2014

Hi @ryanuber!

First of all, thanks a lot for your contribution.

I should document process of contributing better, e.g. man page is auto-generated from inline command help.

I've performed some cleanups and even fixed my own bug in .Merge function, added more system tests. This should go into 0.5

smira added a commit to aptly-dev/aptly-bash-completion that referenced this pull request Apr 23, 2014

@ryanuber

This comment has been minimized.

Copy link
Contributor

ryanuber commented Apr 23, 2014

@smira awesome, looking good!

@ryanuber ryanuber deleted the ryanuber:f-newestpkg branch Apr 23, 2014

smira added a commit to aptly-dev/aptly-dev.github.io that referenced this pull request Apr 23, 2014

@keithchambers

This comment has been minimized.

Copy link

keithchambers commented Apr 23, 2014

Smira, thanks for pulling this in. 👍

Do you plan to cut 5.0 in the next week or so? If so my team can skip integrating this in our internal Jenkins CI pipeline.

@smira

This comment has been minimized.

Copy link
Member

smira commented Apr 23, 2014

@keithchambers, I've already tagged v0.5 in the repository, it would take a day or so for me to produce binary packages and upload them.

@smira

This comment has been minimized.

Copy link
Member

smira commented Apr 24, 2014

aptly 0.5 is available for download!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment