irrigation.py irrigation method 1 has test code hard-code value of 15 mm #132
Comments
Closed
oleksmialyk
added a commit
to oleksmialyk/aquacrop
that referenced
this issue
Jun 24, 2024
I was comparing AquaCrop-OSPy based on AquaCrop v6.1 (2022) vs v7.0 (2024) and found several bugs including: 1) check_groundwater_table.py doesn't return NewCond_zGW variable leading to constant groundwater levels (see aquacropos#99) 2) HIref_current_day.py doesn't check for NewCond_CC_prev <= (Crop.CCmin*Crop.CCx) condition as it used to do in AquaCrop-OSPy v6.1 (perhaps it's how new AquaCrop v7 works, please confirm) 3) irrigation.py has hardcoded 15mm irrigation for IrrMngt_IrrMethod == 1 (see aquacropos#132) 4) root_development.py doesn't return NewCond_rCor which is supposed to be updated daily according to AquaCrop-OSPy v6.1
|
Thanks @Han-Su22 and @oleksmialyk. I've been away these past few weeks, but will look into this over coming days. Clearly an issue with irrigation test that will be an easy fix, and we will check the others raised by Oleks at same time and implement any changes needed |
|
This has now been fixed in last release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello, in irrigation.py for Irr Method 1, there is a hard-coded value put in for testing purposes that was left in. Could you update the main branch by removing the hard code and restoring the main code,
Irr = min(IrrMngt_MaxIrr, IrrReq)? I thought I would raise the issue here so others who use the package for the first time don't have the same issue.The text was updated successfully, but these errors were encountered: