New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/version control meta entities #115

Merged
merged 27 commits into from Feb 9, 2019

Conversation

Projects
None yet
1 participant
@erichanson
Copy link
Contributor

erichanson commented Feb 9, 2019

Meta+bundle versioning much improved.

erichanson added some commits Jan 29, 2019

start version-controlling meta entities
- in `ignored_row`, a `meta.table` or `meta.schema` no longer cascades down to ignore all datums in said table/schema
- create explicit `ignored_schema`, `ignored_relation` and `ignored_column` tabl
es
start using version control to manage `ignored_*`
instead of importing/exporting ignored_row as a special case, start using version control to manage them.  it was wrong before anyway, because ignored_rows weren't commit-specific and couldn't change over time.
make meta.column refer to ONLY table columns, and meta.relation_colum…
…n refer to all columns including views, foreign tables, etc.

this way, we can only version control table columns (since view columns, foreign table columns, etc. are never inserted)

this change will need to be propagated up through endpoint extensively.
add bundle.trackable_nontable_relation for tracking views etc., renam…
…e bundle.not_ignored_* to bundle.trackable_*
new meta.function_definition table, for use in bundling postgresql fu…
…nctions

this is working around a bug in meta.function where argument names (which the function code references) are not included in the parameters field.  they're included in the meta.function_parameters view, which is also just a crappy hack.  generally, meta.function needs to be rewritten and then meta.function_definition and meta.function_parameter can be dropped as well. however, this would have potentially huge ramifications throughout endpoint.select_rows_function, which also needs a rewrite.  and we're just not taking that on right now.  ok.
tracking meta-entities all the way up thru when it hits a `type`! whi…
…ch fails miserably due to lack of updatable view meta.type.
wrapper around pg_catalog.pg_get_functiondef() that clears out search…
…_path, so that all variable references are schema-qualified. (yuck)

@erichanson erichanson merged commit a1aad8b into master Feb 9, 2019

@erichanson erichanson deleted the feature/version-control-meta-entities branch Feb 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment