Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add buildkite/cli and buildkite/agent. #3973

Merged
merged 3 commits into from Jun 14, 2022

Conversation

jklipp
Copy link
Contributor

@jklipp jklipp commented Jun 13, 2022

#3973 buildkite/agent: The Buildkite Agent is an open-source toolkit written in Golang for securely running build jobs on any device or network
#3973 buildkite/cli: A command line interface for Buildkite


Registry definitions to get the build agent and cli tool for the Buildkite CI system.

A commandline interface for Buildkite CI.
@suzuki-shunsuke
Copy link
Member

Thank you for your contribution!

@suzuki-shunsuke suzuki-shunsuke added the enhancement New feature or request label Jun 13, 2022
@suzuki-shunsuke
Copy link
Member

suzuki-shunsuke commented Jun 13, 2022

https://buildkite.com/docs/agent/v3/installation#manual-installation

I'm not familiar with this tool, but it seems that we have to copy a script bootstrap.sh.
I don't know how this script is used, and I don't know if buildkite-agent works well without this script.
Do you know about this script?

cp bootstrap.sh ~/.buildkite-agent/bootstrap.sh

This script is included in the release asset.

$ ls -lh /Users/shunsukesuzuki/.local/share/aquaproj-aqua/pkgs/github_release/github.com/buildkite/agent/v3.36.1/buildkite-agent-darwin-arm64-3.36.1.tar.gz/
total 29M
-rwxr-xr-x  1 shunsukesuzuki staff  745  6 14 07:19 bootstrap.sh
-rwxr-xr-x  1 shunsukesuzuki staff  29M  6 14 07:19 buildkite-agent
-rw-r--r--  1 shunsukesuzuki staff 1.9K  6 14 07:19 buildkite-agent.cfg
drwxr-xr-x 12 shunsukesuzuki staff  384  6 14 07:19 hooks
#!/bin/sh

# This is a shim to make the upgrade process from v2 -> v3 smoother as
# v2 configurations will still have bootstrap-path=/usr/share/buildkite-agent/bootstrap.sh
# which will cause all sorts of wierd behaviour

echo "+++ :warning: Your buildkite-agent.cfg file contains a deprecated bootstrap.sh"
echo "As part of the upgrade from Agent v2 to v3, a bootstrap-script compatibility shim was added to your buildkite-agent.cfg."
echo ""
echo "To silence this warning, you can comment out the bootstrap-script line in ${BUILDKITE_CONFIG_PATH:-buildkite-agent.cfg}."
echo ""
echo "For more information, see our Buildkite Agent 3.0 upgrade guide:"
echo "https://buildkite.com/docs/agent/upgrading-to-v3"

exec buildkite-agent bootstrap "$@"

- type: github_release
repo_owner: buildkite
repo_name: cli
description: "A command line interface for Buildkite."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: "A command line interface for Buildkite."
description: "A command line interface for Buildkite"

https://github.com/aquaproj/aqua-registry/blob/main/CONTRIBUTING.md#remove-a-period-from-the-end-of-the-description

Remove a period from the end of the description

@suzuki-shunsuke
Copy link
Member

#3973 (comment)

It seems that buildkite-agent doesn't call bootstrap.sh so I guess there is no problem.

https://github.com/buildkite/agent/search?q=bootstrap.sh

@jklipp
Copy link
Contributor Author

jklipp commented Jun 14, 2022

#3973 (comment)

It seems that buildkite-agent doesn't call bootstrap.sh so I guess there is no problem.

https://github.com/buildkite/agent/search?q=bootstrap.sh

As far as I can tell it doesn't get called directly. I believe it's there to help migrate up from previous versions, so perhaps not necessary for new installs. We use aqua to install buildkite-agent and the bk cli tool for running buildkite pipelines on local developer machines, but not to install the agent on our actual CI machines. It works without needing the bootstrap.sh moved around for our local use case, but I can't guarantee it's usage in other cases.

@suzuki-shunsuke
Copy link
Member

Thank you for your explanation.
I understood.

@suzuki-shunsuke suzuki-shunsuke self-requested a review June 14, 2022 22:22
@suzuki-shunsuke suzuki-shunsuke merged commit cdbd213 into aquaproj:main Jun 14, 2022
@suzuki-shunsuke suzuki-shunsuke added this to the v2.25.1 milestone Jun 14, 2022
@suzuki-shunsuke
Copy link
Member

Released. https://github.com/aquaproj/aqua-registry/releases/tag/v2.26.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants