fix(pip): remove extras from lines of requirement.txt files #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
knqyf263
reviewed
Apr 24, 2023
pkg/python/pip/parse.go
Outdated
| startIndex := strings.Index(line, startExtras) | ||
| endIndex := strings.Index(line, endExtras) + 1 | ||
| if startIndex != -1 && endIndex != -1 { | ||
| log.Logger.Debugf("unable to get name and version for extras of %q. Run `pip3 freeze > requirements.txt` to update file and get this dependency", line) |
There was a problem hiding this comment.
I don't think we need this message.
setup(
name="example",
...
install_requires=[
"requests"],
extras_require={
'test': ["nose"],
'doc': ["sphinx"],
}
)
In the above example, the following commands download different dependencies.
pip install example[test] # install request and nose
pip install example[doc] # install request and sphinx
pip install example # install request
Even when extras are not specified, we can't get the names and versions of indirect dependencies (requiest in this case). So, recommending pip freeze in our doc is enough.
But thanks for your hospitality👍
There was a problem hiding this comment.
okay, i removed it in 47b299f
knqyf263
approved these changes
Apr 24, 2023
Sq34sy
pushed a commit
to Sq34sy/go-dep-parser
that referenced
this pull request
Jul 28, 2023
Sq34sy
pushed a commit
to Sq34sy/go-dep-parser
that referenced
this pull request
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
requirement.txtcan contain extras. e.g.pyjwt[crypto]==2.1.0We need to find dependency name correctly.