Run audit as shell script instead of as single line command #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #610 +/- ##
==========================================
- Coverage 65.29% 65.12% -0.18%
==========================================
Files 12 12
Lines 1144 1078 -66
==========================================
- Hits 747 702 -45
+ Misses 357 342 -15
+ Partials 40 34 -6
Continue to review full report at Codecov.
|
|
Sorry for being slow on this. From a very quick glance it looks similar to what @yoavrotems did with aquasecurity/bench-common#87 |
|
@lizrice Should i close this PR or use similar codes from aquasecurity/bench-common#87 ? |
mozillazg
force-pushed
the
run-audit-as-shell-script
branch
from
4a6899c
to
680bc64
Compare
|
@yoavrotems ping |
yoavrotems
approved these changes
Jun 21, 2020
caruccio
pushed a commit
to getupcloud/kube-bench
that referenced
this pull request
Feb 19, 2021
…rity#610) * Run audit as shell script instead of as single line command * Rename runExecCommands to runAudit * Fix tests Co-authored-by: Liz Rice <liz@lizrice.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #604