Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying a particular resource name #14

Merged
merged 2 commits into from Jun 7, 2019
Merged

Allow specifying a particular resource name #14

merged 2 commits into from Jun 7, 2019

Conversation

danielpacak
Copy link
Contributor

Resolves #13

@danielpacak danielpacak marked this pull request as ready for review June 6, 2019 07:14
@danielpacak danielpacak requested a review from lizrice June 6, 2019 07:14
@danielpacak danielpacak assigned amitlib and unassigned amitlib Jun 6, 2019
@codecov-io
Copy link

codecov-io commented Jun 6, 2019 •
edited

Codecov Report

Merging #14 into master will increase coverage by 10.18%.
The diff coverage is 40%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #14       +/-   ##
===========================================
+ Coverage   16.43%   26.62%   +10.18%     
===========================================
  Files           2        2               
  Lines         146      169       +23     
===========================================
+ Hits           24       45       +21     
- Misses        122      124        +2
Impacted Files Coverage Δ
cmd/root.go 17.14% <0%> (+1.35%) ⬆️
cmd/list.go 29.1% <41.66%> (+12.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c185aaa...d57c5d0. Read the comment docs.

lizrice
lizrice suggested changes Jun 6, 2019
View reviewed changes
Copy link
Contributor

@lizrice lizrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though the CLI flag parsing seems to have gone awol?

cmd/root.go Show resolved Hide resolved
cmd/list.go Outdated Show resolved Hide resolved
cmd/list_test.go Show resolved Hide resolved
lizrice
lizrice approved these changes Jun 7, 2019
View reviewed changes
Copy link
Contributor

@lizrice lizrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lizrice lizrice merged commit 82800ad into aquasecurity:master Jun 7, 2019
@danielpacak danielpacak deleted the issue_13_resource_name branch June 7, 2019 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizrice lizrice lizrice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow specifying a particular resource name
4 participants
@danielpacak @codecov-io @lizrice @amitlib