Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several error handling issues #142

Merged
merged 1 commit into from Apr 7, 2022

Conversation

kakkoyun
Copy link
Contributor

@kakkoyun kakkoyun commented Apr 7, 2022

Signed-off-by: Kemal Akkoyun kakkoyun@gmail.com

Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
@CLAassistant
Copy link

CLAassistant commented Apr 7, 2022

CLA assistant check
All committers have signed the CLA.

@@ -18,8 +18,11 @@ func SymbolToOffset(path, symbol string) (uint32, error) {
dynamicSymbols, dynamicSymbolsErr := f.DynamicSymbols()

// Only if we failed getting both regular and dynamic symbols - then we abort.
if regularSymbolsErr != nil && dynamicSymbolsErr != nil {
return 0, fmt.Errorf("could not open symbol sections to resolve symbol offset: %w, %w", regularSymbolsErr, dynamicSymbolsErr)
Copy link
Contributor Author

@kakkoyun kakkoyun Apr 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go vet complains about this. Only one error should be wrapped.

@rafaeldtinoco rafaeldtinoco requested a review from grantseltzer Apr 7, 2022
Copy link
Member

@grantseltzer grantseltzer left a comment

Good catches, thank you!

@grantseltzer grantseltzer merged commit 222eac7 into aquasecurity:main Apr 7, 2022
1 check passed
@kakkoyun kakkoyun deleted the fix_error_handling_errors branch Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants