Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error handling in helper function #146

Merged
merged 1 commit into from Apr 14, 2022

Conversation

grantseltzer
Copy link
Member

@grantseltzer grantseltzer commented Apr 11, 2022

As the comment that's been there explains, we only need one symbols section.

Signed-off-by: grantseltzer grantseltzer@gmail.com

Signed-off-by: grantseltzer <grantseltzer@gmail.com>
@grantseltzer grantseltzer requested a review from rafaeldtinoco Apr 11, 2022
Copy link
Contributor

@kakkoyun kakkoyun left a comment

🙈 Oops, I didn't give enough thought on the implications apparently

@grantseltzer
Copy link
Member Author

grantseltzer commented Apr 13, 2022

see_no_evil Oops, I didn't give enough thought on the implications apparently

No worries, I reviewed it, wrote the tests that expose the issue, and wrote the comment describing the challenge :-D

Copy link
Collaborator

@yanivagman yanivagman left a comment

LGTM

@grantseltzer grantseltzer merged commit 3cddef5 into aquasecurity:main Apr 14, 2022
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants