Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement API for checking if map and program types are supported #164

Merged
merged 3 commits into from May 6, 2022

Conversation

grantseltzer
Copy link
Member

@grantseltzer grantseltzer commented May 4, 2022

Signed-off-by: grantseltzer grantseltzer@gmail.com

@grantseltzer grantseltzer changed the title Add helper functions for checking if map and program types are supported Implement API for checking if map and program types are supported May 4, 2022
@rafaeldtinoco
Copy link
Collaborator

rafaeldtinoco commented May 4, 2022

May we have a selftest for Bpf program types as well ?

Signed-off-by: grantseltzer <grantseltzer@gmail.com>
@grantseltzer
Copy link
Member Author

grantseltzer commented May 4, 2022

May we have a selftest for Bpf program types as well ?

Anything for you Rafael

Signed-off-by: grantseltzer <grantseltzer@gmail.com>
@rafaeldtinoco
Copy link
Collaborator

rafaeldtinoco commented May 6, 2022

Reviewing this now!

rafaeldtinoco
rafaeldtinoco previously approved these changes May 6, 2022
Copy link
Collaborator

@rafaeldtinoco rafaeldtinoco left a comment

LGTM. There is a minor alignment issue you can fix before merging.

SEC("kprobe/sys_mmap")
int kprobe__sys_mmap(struct pt_regs *ctx)
{
bpf_printk("Yankees will win the 2022 world series");
Copy link
Collaborator

@rafaeldtinoco rafaeldtinoco May 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: unaligned.

Copy link
Collaborator

@rafaeldtinoco rafaeldtinoco May 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

important: needs a baseball fan review, let's block this until then.

Signed-off-by: grantseltzer <grantseltzer@gmail.com>
@grantseltzer grantseltzer merged commit b5a21bd into aquasecurity:main May 6, 2022
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants