Merged
Conversation
These annotations are useful for tools (such as Renovate and Snyk) to use as well as for manual use by individuals. See: https://github.com/opencontainers/image-spec/blob/v1.1.0/annotations.md#pre-defined-annotation-keys
simar7
reviewed
May 31, 2024
Comment on lines
+31
to
+32
| --annotation "org.opencontainers.image.source=$GITHUB_SERVER_URL/$GITHUB_REPOSITORY" \ | ||
| --annotation "org.opencontainers.image.revision=$GITHUB_SHA" \ |
Member
There was a problem hiding this comment.
What are the values for these variables? Are they documented somewhere?
Contributor
Author
There was a problem hiding this comment.
The annotation semantics are documented at https://github.com/opencontainers/image-spec/blob/v1.1.0/annotations.md#pre-defined-annotation-keys
The environment variables are documented at https://docs.github.com/en/actions/learn-github-actions/variables#default-environment-variables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These annotations are useful for tools (such as Snyk uses them in its UI and Renovate uses them to find release notes) to use as well as for manual use by individuals.
See: https://github.com/opencontainers/image-spec/blob/v1.1.0/annotations.md#pre-defined-annotation-keys
The trivy images at ghcr.io/aquasecurity/trivy and elsewhere already have OCI annotations.