Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
capstone.pc file contains broken includedir #1339
The capstone.pc file that is built in 4.0.1 has regressed in its includedir path:
compared to 3.0.5 which had
This problem was supposedly fixed in #1276 but that only fixes the problem when building with cmake. When using plain make, the capstone.pc.in file is ignored and the 'generate-pkgconfig' make target is called instead.
I'm interested whether it's the intention of capstone developers that the header file is included using:
Note the first variant is used by at least one test: https://github.com/aquynh/capstone/blob/master/tests/test_basic.c
I can certainly hack something, but it's not very easy to fix properly. Ideally the capstone.pc.in file would be the source of truth for both build systems, but at the moment the Makefile has effectively its own copy of that template. However modifying the Makefile to use the template isn't easy either as there are no substitute variables to use. Why does this project have two separate build systems?