Add accessKeyId and secretAccessKey to S3 Client init to remove aws configure dependency #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgive me if this seems unnecessary, but I noticed that
createBucket
fails if you do not have a local~/.aws/configuration
file on your machine, even though this fake S3 server doesn't care about access/secret keys. Output will sayServerless: creating bucket: bucket-name
but it won't actually be created and any errors will be suppressed.In order to bypass this requirement, we can simply pass in dummy text for
accessKeyId
andsecretAccessKey
when initializing the S3 client.I also updated the
getClient
method to use theoptions.host
value instead of hardcoded localhost.