From 66ffbbdb688976756e996313b19ccd2eb31f96c5 Mon Sep 17 00:00:00 2001 From: arafaysaleem Date: Tue, 8 Jun 2021 16:39:47 -0700 Subject: [PATCH 1/2] ci(Actions): remove logging from release workflow for security reasons Signed-off-by: arafaysaleem --- .github/workflows/PR-merge-build-release.yaml | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/.github/workflows/PR-merge-build-release.yaml b/.github/workflows/PR-merge-build-release.yaml index d02a333..665d2b9 100644 --- a/.github/workflows/PR-merge-build-release.yaml +++ b/.github/workflows/PR-merge-build-release.yaml @@ -80,10 +80,6 @@ jobs: with: name: key-properties-artifact #Must be same as upload artifact in previous job path: android #Download to android directory - - name: Log downloaded artifacts - run: | - ls android - cat android/key.properties - uses: actions/setup-java@v1 with: java-version: '12.x' @@ -97,6 +93,8 @@ jobs: run: flutter packages pub run build_runner build --delete-conflicting-outputs - name: Generate Splitted Release APKs run: flutter build apk --target-platform android-arm,android-arm64 --split-per-abi --obfuscate --split-debug-info=./ez_tickets_app/debug_trace + - name: Remove bundled APK + run: rm app.apk - name: Upload Built APKs Artifact uses: actions/upload-artifact@v2.2.3 with: @@ -115,8 +113,6 @@ jobs: with: name: built-apks-artifact #Must be same as upload artifact in previous job path: build/app/outputs/flutter-apk #download all apks to flutter-apk dir - - name: Log downloaded APK artifacts - run: ls build/app/outputs/flutter-apk - name: Bump version and push tag id: generate_tag uses: mathieudutour/github-tag-action@v5.5 From de4951b6cdb3ab6225d89f4a2fe5b83b2c83fda2 Mon Sep 17 00:00:00 2001 From: arafaysaleem Date: Tue, 8 Jun 2021 16:54:48 -0700 Subject: [PATCH 2/2] ci(Actions): Remove bundled release apk from outputs Signed-off-by: arafaysaleem --- .github/workflows/PR-merge-build-release.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/PR-merge-build-release.yaml b/.github/workflows/PR-merge-build-release.yaml index 665d2b9..ed12af2 100644 --- a/.github/workflows/PR-merge-build-release.yaml +++ b/.github/workflows/PR-merge-build-release.yaml @@ -94,7 +94,7 @@ jobs: - name: Generate Splitted Release APKs run: flutter build apk --target-platform android-arm,android-arm64 --split-per-abi --obfuscate --split-debug-info=./ez_tickets_app/debug_trace - name: Remove bundled APK - run: rm app.apk + run: rm build/app/outputs/flutter-apk/app.apk - name: Upload Built APKs Artifact uses: actions/upload-artifact@v2.2.3 with: