New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2019 Q1 board decisions #23

Merged
merged 6 commits into from Jan 18, 2019

Conversation

Projects
None yet
4 participants
@luisivan
Copy link
Member

luisivan commented Jan 17, 2019

No description provided.

@izqui

This comment has been minimized.

Copy link
Member

izqui commented Jan 17, 2019

I support AGP 14 and AGP 16 as they currently stand, but given that they only contain a Github link to another pull request that could be modified by the author, maintainers or Github itself it is too risky to sign such AGP. I will refrain from signing until the AGP text contains the proposal description.

@izqui

This comment has been minimized.

Copy link
Member

izqui commented Jan 17, 2019

I won't be gaining access to my PGP key until tomorrow afternoon CET.

But this is my pre-commitment:

  • To approve: AGPs 5, 10, 11, 12, 17, 18, 19
  • To reject: AGPs 7, 8, 9
  • To approve iff properly specified: AGPs 14, 16 (if not scoped in 14)

@john-light john-light requested review from john-light and lkngtn Jan 18, 2019

luisivan and others added some commits Jan 18, 2019

@john-light john-light requested a review from izqui Jan 18, 2019

@john-light john-light removed the request for review from izqui Jan 18, 2019

@lkngtn

This comment has been minimized.

Copy link
Member

lkngtn commented Jan 18, 2019

LGTM 👍

@lkngtn

lkngtn approved these changes Jan 18, 2019

@lkngtn lkngtn merged commit e62eb44 into master Jan 18, 2019

1 check passed

license/cla Contributor License Agreement is signed.
Details

@lkngtn lkngtn deleted the 2019-q1-board-decisions branch Jan 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment