Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ganache && fixes to devchain parametrization #79

Merged
merged 4 commits into from Sep 12, 2019

Conversation

@0xGabi
Copy link
Member

commented Sep 11, 2019

We are not able to update the default balance of accounts once the snapshot was created (as far as I understood) as discussed here. There were some use cases reported by a user that he needed a higher amount of ETH so we have set 10,000 as initial balance in the snapshot.

0xGabi added 2 commits Sep 11, 2019
@0xGabi 0xGabi changed the title Update ganache && fixes to devchain parametization Update ganache && fixes to devchain parametrization Sep 11, 2019
0xGabi added 2 commits Sep 12, 2019
@0xGabi 0xGabi merged commit b8345b2 into aragon:master Sep 12, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details
@0xGabi 0xGabi deleted the 0xGabi:5.3.0 branch Sep 12, 2019
@@ -59,7 +59,7 @@
"@aragon/os": "^4.2.0",
"@aragon/apps-shared-minime": "^1.0.0",
"eth-ens-namehash": "^2.0.8",
"ganache-cli": "~6.2.0",
"ganache-cli": "^6.7.0",

This comment has been minimized.

Copy link
@sohkai

sohkai Oct 9, 2019

Member

@0xGabi I remember us rolling back to 6.2.0 due to a forwarding bug; did we test that it was resolved on newer ganache-core versions?

Ahh... I see ganache-core@2.8.0 has this exact fix :).

This comment has been minimized.

Copy link
@0xGabi

0xGabi Oct 9, 2019

Author Member

Yes 🎉

@@ -66,16 +55,14 @@ exports.builder = yargs => {
default: false,
type: 'boolean',
description: 'Enable verbose devchain output',
alias: 'v',
alias: 'd',

This comment has been minimized.

Copy link
@sohkai

sohkai Oct 9, 2019

Member

Usually verbose is shortened to v; as well, this would constitute a major version change since it's part of the external API.

This comment has been minimized.

Copy link
@0xGabi

0xGabi Oct 9, 2019

Author Member

Oh yes, I decide to include alias to have a similar syntax as ganache. Then I realize that there were a clash between the aragon --version alias and this alias on the devchain. What would be your suggestion in this case? Better not having the v alias on aragonCLI instead?

This comment has been minimized.

Copy link
@sohkai

sohkai Oct 9, 2019

Member

Hmm, good question, the two might be mutually compatible, but confusing.

aragon -v
aragon devchain -v`

Of those two, I think aragon devchain -v is more important, and mirrors ganache-cli's flag.

@0xGabi 0xGabi referenced this pull request Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.