DisputableVoting: Optimize quiet ending #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facuspagnuolo
changed the title
bingen
reviewed
Jul 29, 2020
| } else { | ||
| // First, we make sure the extension is persisted, if are voting within the extension and it was not considered yet, we store it. | ||
| // Note that we are trusting `_canVote`, if we reached this point, it means the vote's flip was already confirmed. | ||
| if (getTimestamp64() >= _finalVoteEndDate(vote_)) { |
There was a problem hiding this comment.
This is definitely quite counter-intuitive! haha (but looks fine to me)
There was a problem hiding this comment.
I see, honestly I couldn't come up with a clearer but similarly optimized as this one to compute multiple extensions
| }) | ||
| }) | ||
| }) | ||
| }) |
|
@bingen thx a lot for the review! let me know your thoughts :D |
… into improve_quiet_ending
bingen
approved these changes
Jul 30, 2020
| @@ -256,10 +256,10 @@ contract DisputableVoting is IForwarder, DisputableAragonApp { | |||
| * @param _supports Whether voter supports the vote | |||
| */ | |||
| function vote(uint256 _voteId, bool _supports) external { | |||
| Vote storage vote_ = _getVote(_voteId); | |||
| require(_canVote(vote_, msg.sender), ERROR_CANNOT_VOTE); | |||
| Vote storage _vote = _getVote(_voteId); | |||
There was a problem hiding this comment.
I meant only for function params, but this looks fine to me too.
ramilexe
pushed a commit
to ConsiderItDone/aragon-apps
that referenced
this pull request
Dec 9, 2021
* DisputableVoting: Improve quiet ending * DisputableVoting: Make `wasFlipped` implementation clearer * DisputableVoting: Use `_` prefix instead of suffix for vote storage variables * DisputableVoting: Fix linter * DisputableVoting: Use `_` prefix only for args
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an improvement to the quiet ending feature. The main purpose is to compare the result at the beginning and at the end of the quiet ending period, and extend it only if it differs.