Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Token-manager: use bn.js #432
The PR allows the assigning/minting of sums larger than 100.
When discussed with @sohkai, Brett suggested converting the strings to BN.js object in the web worker. When done that way, the BN.js objects were serialised as normal objects with the BN.js properties and required reinitialisation in the react application. Therefor I left the numbers in the worker as strings.
Sorted the balances to match the stake percentage table for a more coherent UI.
Sweet! Would be good to add tests as a next step too.
On Mon, 24 Sep 2018 at 13:38 Coveralls ***@***.***> wrote: [image: Coverage Status] <https://coveralls.io/builds/19154017> Coverage decreased (-0.8%) to 96.212% when pulling *f996026 <f996026> on 2color:use-bn* into *d62f2b6 <d62f2b6> on aragon:master*. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#432 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AB5mP-s1uthCZKx0Rb9AzVA_8DA3FrBxks5ueMQzgaJpZM4WgBS3> .
-- Daniel Norman