New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vault: remove ability to call contracts with data #492

Merged
merged 2 commits into from Oct 16, 2018

Conversation

Projects
None yet
3 participants
@bingen
Copy link
Contributor

bingen commented Oct 16, 2018

Closes #488.

@bingen bingen added this to the Sprint: 2.2 milestone Oct 16, 2018

@bingen bingen self-assigned this Oct 16, 2018

@bingen bingen requested review from izqui and sohkai Oct 16, 2018

@bingen bingen force-pushed the issue489 branch 2 times, most recently from 53fbbad to 0a03455 Oct 16, 2018

@bingen bingen force-pushed the issue488 branch from c6e7f4d to 7564932 Oct 16, 2018

@sohkai

sohkai approved these changes Oct 16, 2018

assert.equal((await getBalance(testAccount)).toString(), initialBalance.add(transferValue * 2).toString(), "should have sent eth")
assert.equal((await getBalance(vault.address)).toString(), depositValue - transferValue * 2, "should have remaining balance")
*/

This comment has been minimized.

@sohkai

sohkai Oct 16, 2018

Member

We could add a test with a mock that does too much in its fallback function (e.g. setting some state) to make sure we're only transferring 2.3k gas with transfer().

@izqui

izqui approved these changes Oct 16, 2018

Vault: remove ability to call contracts with data
Add test to check only plain transfers are allowed.
Address PR #492 comments.

@bingen bingen changed the base branch from issue489 to master Oct 16, 2018

@bingen bingen merged commit 23057c4 into master Oct 16, 2018

1 of 4 checks passed

License Compliance FOSSA is analyzing this commit
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
license/cla Contributor License Agreement is signed.
Details

@sohkai sohkai deleted the issue488 branch Oct 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment