New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Payment to RecurringPayment #565

Merged
merged 4 commits into from Dec 14, 2018

Conversation

Projects
None yet
4 participants
@IvanTheGreatDev
Copy link
Contributor

IvanTheGreatDev commented Nov 6, 2018

Resolves #375

(Am still away, I'll do some more advanced PRs when I'm back haha)

@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 6, 2018

Coverage Status

Coverage remained the same at 96.124% when pulling 4b8f395 on IvanTheGreatDev:hotfix/rename-payment-struct into b9ee11b on aragon:master.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 6, 2018

Coverage Status

Coverage remained the same at 96.124% when pulling 4b8f395 on IvanTheGreatDev:hotfix/rename-payment-struct into b9ee11b on aragon:master.

@sohkai

sohkai approved these changes Nov 15, 2018

Copy link
Member

sohkai left a comment

💫 Looks good!

I think it might be to start a new branch for contract changes, so we can review them again when we're ready to deploy upgrades cc @izqui @bingen

@@ -312,7 +311,7 @@ contract Finance is EtherTokenConstant, IsContract, AragonApp {
*/
function executePayment(uint256 _paymentId)
external
authP(EXECUTE_PAYMENTS_ROLE, arr(_paymentId, payments[_paymentId].amount))
authP(EXECUTE_PAYMENTS_ROLE, arr(_paymentId, recurringPayments[_paymentId].amount))
paymentExists(_paymentId)

This comment has been minimized.

@sohkai

sohkai Nov 15, 2018

Member

Let's rename this recurringPaymentExists to align it with the name of the mapping.

@bingen

This comment has been minimized.

Copy link
Contributor

bingen commented Nov 18, 2018

Yes, @sohkai that sounds good.

@sohkai sohkai changed the base branch from master to next Dec 14, 2018

sohkai added some commits Dec 14, 2018

@sohkai sohkai merged commit e0884ed into aragon:next Dec 14, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment