Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finance: use aragonAPI for React #765

Merged
merged 5 commits into from Apr 5, 2019

Conversation

Projects
None yet
4 participants
@bpierre
Copy link
Member

bpierre commented Apr 5, 2019

Contains only the changes needed to support aragonAPI for React (not a full conversion to React Hooks).

@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 5, 2019

Coverage Status

Coverage remained the same at 96.734% when pulling 8130eb3 on finance-react-api into aff584e on master.

@bpierre bpierre force-pushed the finance-react-api branch from 8130eb3 to 63221ce Apr 5, 2019

@bpierre bpierre referenced this pull request Apr 5, 2019

Merged

Finance filters refresh #767

@bpierre bpierre requested a review from sohkai Apr 5, 2019

@luisivan luisivan referenced this pull request Apr 5, 2019

Closed

Responsive #4

39 of 46 tasks complete

@bpierre bpierre requested a review from 2color Apr 5, 2019

@sohkai

sohkai approved these changes Apr 5, 2019

Copy link
Member

sohkai left a comment

LGTM! 🐎 🏇 🏎

We could do the MenuPanel change here too :).

Show resolved Hide resolved apps/finance/app/src/App.js

bpierre added some commits Apr 5, 2019

@bpierre bpierre merged commit e5078ff into master Apr 5, 2019

1 of 4 checks passed

License Compliance FOSSA is analyzing this commit
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
license/cla Contributor License Agreement is signed.
Details

@bpierre bpierre deleted the finance-react-api branch Apr 5, 2019

@2color

This comment has been minimized.

Copy link
Contributor

2color commented Apr 8, 2019

🎆👏🏼🥊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.