Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payroll: Improve timestamps mocking #766

Merged
merged 1 commit into from Apr 8, 2019

Conversation

Projects
None yet
3 participants
@facuspagnuolo
Copy link
Contributor

facuspagnuolo commented Apr 5, 2019

This PR improves timestamp mocking in a more consistent way and provides a new common mocking contract that can be easily re-used.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 5, 2019

Coverage Status

Coverage remained the same at 96.734% when pulling 2d39366 on improve_timestamps_mocking into e5078ff on master.

@aragon aragon deleted a comment from coveralls Apr 5, 2019

@facuspagnuolo

This comment has been minimized.

Copy link
Contributor Author

facuspagnuolo commented Apr 5, 2019

I wouldn't be finding why the coverage has decreased, any hints where should I look?

@sohkai

This comment has been minimized.

Copy link
Member

sohkai commented Apr 5, 2019

I wouldn't be finding why the coverage has decreased, any hints where should I look?

Probably due to the number of coverage lines being decreased 🤷‍♂️.


@facuspagnuolo Could you make this PR solely against Payroll, and then we'll open another one for the other apps? The reason is that the tests and contracts have changed in the next branch and we should work off of there instead.

@sohkai

sohkai approved these changes Apr 5, 2019

@facuspagnuolo facuspagnuolo force-pushed the improve_timestamps_mocking branch from 293dbc9 to 2d39366 Apr 7, 2019

@facuspagnuolo facuspagnuolo changed the title Shared: Improve timestamps mocking Payroll: Improve timestamps mocking Apr 7, 2019

@facuspagnuolo facuspagnuolo merged commit c4c936f into master Apr 8, 2019

4 of 5 checks passed

License Compliance 1 issues found
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 96.734%
Details
license/cla Contributor License Agreement is signed.
Details

@facuspagnuolo facuspagnuolo deleted the improve_timestamps_mocking branch Apr 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.