Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token Manager: small improvements for ITokenController interface #770

Merged
merged 1 commit into from Apr 10, 2019

Conversation

Projects
None yet
3 participants
@sohkai
Copy link
Member

sohkai commented Apr 5, 2019

Changes the ITokenController methods to be external, as they never need to be called from within the Token Manager itself.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 5, 2019

Coverage Status

Coverage remained the same at 97.015% when pulling 94ca511 on token-manager-minime-improvements into a66f876 on next.

2 similar comments
@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 5, 2019

Coverage Status

Coverage remained the same at 97.015% when pulling 94ca511 on token-manager-minime-improvements into a66f876 on next.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 5, 2019

Coverage Status

Coverage remained the same at 97.015% when pulling 94ca511 on token-manager-minime-improvements into a66f876 on next.

@tintinweb

This comment has been minimized.

Copy link

tintinweb commented Apr 10, 2019

✓ minor changed func visibility -> pub->ext; lex. move func (no change)

@sohkai sohkai merged commit 1af7a59 into next Apr 10, 2019

5 checks passed

License Compliance All checks passed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 97.015%
Details
license/cla Contributor License Agreement is signed.
Details

@sohkai sohkai deleted the token-manager-minime-improvements branch Apr 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.