Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token manager copy #773

Merged
merged 3 commits into from Apr 10, 2019

Conversation

Projects
None yet
5 participants
@bpierre
Copy link
Member

bpierre commented Apr 5, 2019

Builds on #764 (do not merge before)
Fixes #509

See also aragonone/product#41 (comment)

Preview

Screenshot from 2019-04-05 15-58-36
Screenshot from 2019-04-05 15-59-31
Screenshot from 2019-04-05 15-59-45
Screenshot from 2019-04-05 16-00-00
Screenshot from 2019-04-05 16-00-06
Screenshot from 2019-04-05 16-00-15
Screenshot from 2019-04-05 16-00-43

@bpierre bpierre requested review from 2color, sohkai and dizzypaty Apr 5, 2019

@dizzypaty
Copy link
Member

dizzypaty left a comment

💥🙌🏻

actionText="Assign Tokens"
title="There are no tokens added yet"
text="Add tokens to get started."
actionText="Add Tokens"

This comment has been minimized.

Copy link
@sohkai

sohkai Apr 5, 2019

Member

@dizzypaty I wonder if we could use some language like

"There are no token holders yet"

"Add tokens to an address to get started"

This comment has been minimized.

Copy link
@dizzypaty

dizzypaty Apr 5, 2019

Member

Yes, that sounds better!

@sohkai

sohkai approved these changes Apr 5, 2019

Copy link
Member

sohkai left a comment

✍️

@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 5, 2019

Coverage Status

Coverage remained the same at 96.734% when pulling d407d03 on token-manager-copy into c1256f0 on master.

bpierre and others added some commits Apr 5, 2019

@sohkai sohkai force-pushed the token-manager-copy branch from d407d03 to 921e52a Apr 10, 2019

@sohkai sohkai merged commit 553fef8 into master Apr 10, 2019

1 of 4 checks passed

License Compliance FOSSA is analyzing this commit
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
license/cla Contributor License Agreement is signed.
Details

@sohkai sohkai deleted the token-manager-copy branch Apr 10, 2019

@john-light

This comment has been minimized.

Copy link
Member

john-light commented Apr 18, 2019

I'm wondering how this fixes #509 when "Remove tokens" is still called that in the Token Manager but it's called "Burn token" in the Permissions app?

@sohkai

This comment has been minimized.

Copy link
Member

sohkai commented Apr 18, 2019

@john-light Good point, re-opened #509 since it's more related to permissions metadata than renaming the action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.