Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payroll: Implement accrued salary #774

Merged
merged 4 commits into from Apr 16, 2019

Conversation

Projects
None yet
3 participants
@facuspagnuolo
Copy link
Contributor

facuspagnuolo commented Apr 5, 2019

Fixes #761

@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 6, 2019

Coverage Status

Coverage remained the same at 96.629% when pulling 98061c1 on implement_accrued_salary into b95445e on master.

@sohkai

sohkai approved these changes Apr 15, 2019

Copy link
Member

sohkai left a comment

👍

I noticed some of the changes have been modified in later PRs, so let's work off of those :).

facuspagnuolo added a commit that referenced this pull request Apr 15, 2019

@facuspagnuolo

This comment has been minimized.

Copy link
Contributor Author

facuspagnuolo commented Apr 15, 2019

Addressed feedback from @sohkai here 7e09745

@facuspagnuolo facuspagnuolo merged commit 54b4784 into master Apr 16, 2019

3 of 5 checks passed

coverage/coveralls Coverage decreased (-0.1%) to 96.629%
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
License Compliance All checks passed.
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

facuspagnuolo added a commit that referenced this pull request Apr 16, 2019

Payroll: Ceil last payroll date calculation (#776)
* Payroll: Rename payment `reference` to `paymentReference`

* Payroll: Remove return values from `_payday` and `_reimburse` functions

* Payroll: Implement accrued salary

* Payroll: Support employees bonus

* Payroll: Ceil last payroll date calculation

* Payroll: Address feedback from @sohkai in #774

* Payroll: Address feedback from @sohkai in #775

* Payroll: Address feedback from @sohkai in #776

* Payroll: Fix compiler warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.