Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payroll: Add reentrancy guard to payment transfers #778

Merged
merged 1 commit into from Apr 17, 2019

Conversation

Projects
None yet
3 participants
@facuspagnuolo
Copy link
Contributor

facuspagnuolo commented Apr 8, 2019

Fixes #759

The CI failed because we reached the max size limit of a contract, I'm proposing to simplify the external interface removing some redundant functions. I'm dropping addEmployeeNow and terminateEmployeeNow, in favour of leaving simply addEmployee and terminateEmployee.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 8, 2019

Coverage Status

Coverage remained the same at 96.734% when pulling 740d2e4 on add_reentracy_guard_payroll into 77261c8 on ensure_payroll_divisions.

@sohkai

sohkai approved these changes Apr 15, 2019

Copy link
Member

sohkai left a comment

👍

Show resolved Hide resolved future-apps/payroll/contracts/Payroll.sol Outdated

@facuspagnuolo facuspagnuolo changed the base branch from ensure_payroll_divisions to master Apr 16, 2019

@facuspagnuolo facuspagnuolo force-pushed the add_reentracy_guard_payroll branch from 740d2e4 to 19e5e72 Apr 16, 2019

@facuspagnuolo facuspagnuolo changed the title [DO NOT MERGE] Payroll: Add reentrancy guard to payment transfers Payroll: Add reentrancy guard to payment transfers Apr 16, 2019

@sohkai

sohkai approved these changes Apr 16, 2019

@facuspagnuolo facuspagnuolo force-pushed the add_reentracy_guard_payroll branch from 19e5e72 to cbf9d7f Apr 16, 2019

@facuspagnuolo

This comment has been minimized.

Copy link
Contributor Author

facuspagnuolo commented Apr 16, 2019

@sohkai would be great if you can take another look at these changes. I updated the description and added some tests.

@facuspagnuolo facuspagnuolo force-pushed the add_reentracy_guard_payroll branch from cbf9d7f to db60d64 Apr 16, 2019

@facuspagnuolo facuspagnuolo changed the base branch from master to fix_price_feed_usage Apr 16, 2019

@facuspagnuolo facuspagnuolo changed the base branch from fix_price_feed_usage to master Apr 16, 2019

@facuspagnuolo facuspagnuolo force-pushed the add_reentracy_guard_payroll branch from db60d64 to f61723e Apr 16, 2019

@facuspagnuolo facuspagnuolo changed the base branch from master to fix_price_feed_usage Apr 16, 2019

@sohkai

sohkai approved these changes Apr 16, 2019


return true;
}
}

This comment has been minimized.

Copy link
@sohkai

sohkai Apr 16, 2019

Member

😍 😍 😍

@facuspagnuolo facuspagnuolo force-pushed the fix_price_feed_usage branch from b7bec0b to 3199767 Apr 16, 2019

@facuspagnuolo facuspagnuolo changed the base branch from fix_price_feed_usage to master Apr 17, 2019

@facuspagnuolo facuspagnuolo force-pushed the add_reentracy_guard_payroll branch from f61723e to f136731 Apr 17, 2019

@facuspagnuolo facuspagnuolo force-pushed the add_reentracy_guard_payroll branch from f136731 to 9d29a02 Apr 17, 2019

@facuspagnuolo facuspagnuolo merged commit eaf09e7 into master Apr 17, 2019

3 checks passed

License Compliance All checks passed.
Details
coverage/coveralls First build on add_reentracy_guard_payroll at 97.015%
Details
license/cla Contributor License Agreement is signed.
Details

@facuspagnuolo facuspagnuolo deleted the add_reentracy_guard_payroll branch Apr 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.