Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared: Use time helpers mock in all apps #786

Merged
merged 1 commit into from Apr 17, 2019

Conversation

Projects
None yet
2 participants
@facuspagnuolo
Copy link
Contributor

facuspagnuolo commented Apr 12, 2019

No description provided.

@facuspagnuolo facuspagnuolo requested a review from sohkai Apr 12, 2019

@sohkai

sohkai approved these changes Apr 12, 2019

Copy link
Member

sohkai left a comment

😍

@facuspagnuolo facuspagnuolo force-pushed the time_helpers_mock branch from 4981de5 to 1a9cdf7 Apr 12, 2019

@facuspagnuolo facuspagnuolo changed the base branch from master to update_payroll_w_finance Apr 12, 2019

@facuspagnuolo

This comment has been minimized.

Copy link
Contributor Author

facuspagnuolo commented Apr 12, 2019

@sohkai I improved some of the tests to use increasteTime instead of mocking it every time. Feel free to take another look at it.

@facuspagnuolo facuspagnuolo force-pushed the time_helpers_mock branch 2 times, most recently from fd0d26c to 6ba72d4 Apr 12, 2019

@facuspagnuolo facuspagnuolo changed the base branch from update_payroll_w_finance to master Apr 13, 2019

@aragon aragon deleted a comment from coveralls Apr 13, 2019

@sohkai

This comment has been minimized.

Copy link
Member

sohkai commented Apr 14, 2019

@facuspagnuolo Looks like the instrumentation during coverage fails due to the new mocks :/. Wonder if we have to add it to the skip list or etc.

@facuspagnuolo facuspagnuolo force-pushed the time_helpers_mock branch from 6ba72d4 to 4a283d0 Apr 15, 2019

@facuspagnuolo

This comment has been minimized.

Copy link
Contributor Author

facuspagnuolo commented Apr 15, 2019

@sohkai solidity-coverage is actually failing due to a compilation error that doesn't make sense, it is failing due to the functions being overwritten in the time helpers mock with the following message:

TypeError: Overriding function changes state mutability from "nonpayable" to "view"
@sohkai

This comment has been minimized.

Copy link
Member

sohkai commented Apr 15, 2019

@facuspagnuolo That's why I think it's due to some instrumentation issue... usually that's the case if we have a view function declared in a contract whose instrumentation gets skipped but another contract that does not get skipped overrides it (since solidity-coverage strips away the view).

Let's not worry about this too much for now and look into it a bit later :).

@facuspagnuolo facuspagnuolo force-pushed the time_helpers_mock branch from 4a283d0 to 6292397 Apr 16, 2019

@facuspagnuolo facuspagnuolo force-pushed the time_helpers_mock branch from 6292397 to e74e51d Apr 16, 2019

@facuspagnuolo facuspagnuolo merged commit 92fd5e5 into master Apr 17, 2019

3 checks passed

License Compliance All checks passed.
Details
coverage/coveralls First build on time_helpers_mock at 97.015%
Details
license/cla Contributor License Agreement is signed.
Details

@facuspagnuolo facuspagnuolo deleted the time_helpers_mock branch Apr 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.