Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finance, Token Manager: fix panels #791

Merged
merged 3 commits into from Apr 14, 2019

Conversation

Projects
None yet
3 participants
@sohkai
Copy link
Member

sohkai commented Apr 14, 2019

Uses createRef() and adds a few enhancements to Finance's panels:

  • Avoid flickering when closing the panel
  • Reset the panel's state, so re-opening the deposit or withdraw after sending a transaction doesn't display the same information
  • Auto focus the withdraw address panel
  • Display a better message when the user has no tokens to deposit

Not super nice, but good enough for now 馃槃.

sohkai added some commits Apr 14, 2019

@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 14, 2019

Coverage Status

Coverage increased (+0.4%) to 97.015% when pulling f22fe0b on fix-panels into caa3de0 on master.

@sohkai sohkai merged commit 8a634fe into master Apr 14, 2019

4 of 5 checks passed

License Compliance 1 issues found
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.4%) to 97.015%
Details
license/cla Contributor License Agreement is signed.
Details

@sohkai sohkai deleted the fix-panels branch Apr 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.