Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payroll: remove unnecessary variable in internal method #842

Merged
merged 1 commit into from May 13, 2019

Conversation

Projects
None yet
3 participants
@sohkai
Copy link
Member

commented May 10, 2019

馃檲 Oops, forgot to remove this as part of 3eab68a.

It's not needed anymore, because we calculate the last payroll date based on the actual amount paid rather than short circuiting it to now if it's the same as the currently owed amount.

@coveralls

This comment has been minimized.

Copy link

commented May 10, 2019

Coverage Status

Coverage remained the same at 97.015% when pulling 2046df0 on payroll-fix-unnecessary-argument into 3b046c1 on master.

@facuspagnuolo
Copy link
Contributor

left a comment

馃憤

@sohkai sohkai merged commit 5f57c91 into master May 13, 2019

5 checks passed

License Compliance Analysis timed out. Check FOSSA for updates.
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
coverage/coveralls Coverage remained the same at 97.015%
Details
license/cla Contributor License Agreement is signed.
Details

@sohkai sohkai deleted the payroll-fix-unnecessary-argument branch May 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.