Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finance: explicitly include core-js@2 #844

Merged
merged 1 commit into from May 10, 2019

Conversation

Projects
None yet
2 participants
@sohkai
Copy link
Member

commented May 10, 2019

Babel@7.4.0 is deprecating core-js@2 and @babel/polyfill, so it will by default try to select core-js@3.

Luckily for Finance, we had another module that used core-js@2 so we got the correct version. This introduces an explicit dependency for this until we want to upgrade to core-js@3 (unfortunately it produces a bigger bundle 馃槮)

@sohkai sohkai merged commit db4515c into master May 10, 2019

1 of 4 checks passed

Travis CI - Pull Request Build Errored
Details
Travis CI - Branch Build Failed
Details
License Compliance FOSSA is analyzing this commit
Details
license/cla Contributor License Agreement is signed.
Details

@sohkai sohkai deleted the finance-add-core-js2 branch May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.