Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Token manager - loading state (with real states) #868

Merged
merged 17 commits into from May 29, 2019
Merged

Token manager - loading state (with real states) #868

merged 17 commits into from May 29, 2019

Conversation

2color
Copy link
Contributor

@2color 2color commented May 24, 2019 •
edited

What

Required PRs:

@2color 2color requested review from bpierre and sohkai May 24, 2019 09:45
@2color 2color changed the title Token manager - loading state (with real data) Token manager - loading state (with real states) May 24, 2019
@2color 2color mentioned this pull request May 24, 2019
Closed
1 task
@sohkai sohkai mentioned this pull request May 27, 2019
Closed
@luisivan luisivan mentioned this pull request May 27, 2019
Closed
25 tasks
@2color 2color requested a review from sohkai May 29, 2019 09:27
@2color 2color marked this pull request as ready for review May 29, 2019 09:32
sohkai
sohkai approved these changes May 29, 2019
View reviewed changes
Copy link
Contributor

@sohkai sohkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡️ ➕ ⚡️

bpierre
bpierre approved these changes May 29, 2019
View reviewed changes
Copy link
Contributor

@bpierre bpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙆‍♂️

@2color
Merge remote-tracking branch 'origin/master' into token-manager-loadi…
cc2aa66 
…ng-state

* origin/master:
  Apps: update for @aragon/rpc-messenger's new deferred behaviour (#871)
  Travis: optimizations and refactor to use build stages (#865)
  Update Travis CI badge (#866)
  Hoist common dependencies (#863)
@2color 2color merged commit cc2aa66 into token-manager-use-init-api May 29, 2019
@2color 2color deleted the token-manager-loading-state branch May 29, 2019 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AquiGorka AquiGorka AquiGorka left review comments

@bpierre bpierre bpierre approved these changes

@sohkai sohkai sohkai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@2color @bpierre @AquiGorka @sohkai