Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payroll: Remove unused import #897

Merged
merged 1 commit into from Jul 3, 2019

Conversation

Projects
None yet
3 participants
@facuspagnuolo
Copy link
Contributor

commented Jul 3, 2019

Fixing finding 6.8 of audit report

6.8 Payroll - Unused Import SafeMath8

Severity Status Remediation Comment
Minor Open This issue is currently under review.

Description

Payroll imports SafeMath8 but it is never used.

code/payroll/future-apps/payroll/contracts/Payroll.sol:L10

import "@aragon/os/contracts/lib/math/SafeMath8.sol";

Remediation

Remove the unused import statement.

@facuspagnuolo facuspagnuolo requested a review from sohkai Jul 3, 2019

@facuspagnuolo facuspagnuolo self-assigned this Jul 3, 2019

@sohkai

sohkai approved these changes Jul 3, 2019

@coveralls

This comment has been minimized.

Copy link

commented Jul 3, 2019

Coverage Status

Coverage increased (+0.5%) to 98.232% when pulling a580b34 on payroll/remove_unused_safemath_import into b989638 on master.

@facuspagnuolo facuspagnuolo merged commit c120ddb into master Jul 3, 2019

5 of 6 checks passed

License Compliance Analysis done, scanning for issues...
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
coverage/coveralls Coverage increased (+0.5%) to 98.232%
Details
license/cla Contributor License Agreement is signed.
Details

@facuspagnuolo facuspagnuolo deleted the payroll/remove_unused_safemath_import branch Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.