Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payroll: Add owed salary getter function #900

Merged
merged 1 commit into from Jul 3, 2019

Conversation

Projects
None yet
3 participants
@facuspagnuolo
Copy link
Contributor

commented Jul 3, 2019

Fixing finding 6.7 of the audit report

6.7 Create an external function to view employees balance

Severity Status Remediation Comment
Minor Open This issue is currently under review.

Description

There is no simple way to find out how much money an employee can withdraw as a payroll. Even though the employee can withdraw the maximum amount by simply passing 0 as _requestedAmount parameter, it would still be useful to have that information accessible through the external view function.

Remediation

Create an external view function that returns the amount of money that can be currently withdrawn from Payroll by an employee.

@facuspagnuolo facuspagnuolo requested a review from sohkai Jul 3, 2019

@facuspagnuolo facuspagnuolo self-assigned this Jul 3, 2019

@sohkai

sohkai approved these changes Jul 3, 2019

Copy link
Member

left a comment

👍 Great tests, as always 🙇

@facuspagnuolo facuspagnuolo force-pushed the payroll/add_owed_salary_getter_fn branch from 11a5707 to 2966385 Jul 3, 2019

@coveralls

This comment has been minimized.

Copy link

commented Jul 3, 2019

Coverage Status

Coverage decreased (-0.009%) to 97.732% when pulling 2966385 on payroll/add_owed_salary_getter_fn into b989638 on master.

@facuspagnuolo facuspagnuolo merged commit 4207ef0 into master Jul 3, 2019

4 of 6 checks passed

coverage/coveralls Coverage decreased (-0.009%) to 97.732%
Details
License Compliance Analysis done, scanning for issues...
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@facuspagnuolo facuspagnuolo deleted the payroll/add_owed_salary_getter_fn branch Jul 3, 2019

@luisivan luisivan referenced this pull request Jul 5, 2019

Open

Payroll #6

14 of 20 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.