Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Payroll: Support employee's min acceptable exchange rates #904
Fixing finding 6.2 of the audit report
6.2 Employee should be able limit exchange rate
An employee has no control over the exchange rate feed and there is (almost) no way to ensure that the payroll will not be transferred using very unfair rate.
Just like when you trade on the exchange, you usually submit a maximum price for which you are willing to buy the tokens, any employee should also be able to limit losses from untrusted exchange rate feeds.
Add the ability for an employee to submit minimal exchange rates that are acceptable for the payroll. This can be done by passing an array with minimal rates to
sohkai left a comment
Ahh, I think we may have miscommunicated a bit here.
What do you think about just adding the ability to specify a min rate in the
I don't like the approach of including this at the token distribution level because it sets the min rate at the wrong time. In my mind, the purpose of this floor is to guarantee that you won't get screwed by an adverse change in the pricefeed when attempting to cash out. If you think the current exchange rate of a token is too high, you simply choose to not invoke