Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prepublish script before publishing to aragonPM #905

Merged
merged 3 commits into from Jul 16, 2019

Conversation

Projects
None yet
4 participants
@sohkai
Copy link
Member

commented Jul 5, 2019

Requires aragon/aragon-cli#571 (and the aragonCLI upgrade).

cc @0xGabi

@coveralls

This comment has been minimized.

Copy link

commented Jul 5, 2019

Coverage Status

Coverage remained the same at 97.732% when pulling a0ee042 on apm-prepublish into 4207ef0 on master.

3 similar comments
@coveralls

This comment has been minimized.

Copy link

commented Jul 5, 2019

Coverage Status

Coverage remained the same at 97.732% when pulling a0ee042 on apm-prepublish into 4207ef0 on master.

@coveralls

This comment has been minimized.

Copy link

commented Jul 5, 2019

Coverage Status

Coverage remained the same at 97.732% when pulling a0ee042 on apm-prepublish into 4207ef0 on master.

@coveralls

This comment has been minimized.

Copy link

commented Jul 5, 2019

Coverage Status

Coverage remained the same at 97.732% when pulling a0ee042 on apm-prepublish into 4207ef0 on master.

@coveralls

This comment has been minimized.

Copy link

commented Jul 5, 2019

Coverage Status

Coverage decreased (-0.2%) to 98.259% when pulling 275d279 on apm-prepublish into 3126dc4 on master.

@0xGabi

This comment has been minimized.

Copy link
Member

commented Jul 5, 2019

LGTM

We will probably release a major version for the aragonCLI cause we introduced a breaking change making ipfs optional.

We could also release a minor only with the PRs for updating apm publish.

@0xGabi

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

aragon apm publish now needs confirmation so I included the --skip-confirmation flag to skip confirmation.

@sohkai What do you think about propagate content. Is this something we want to do as default on each publish? There is a new flag: --propagate-content that we might want to configure as well.

@sohkai

This comment has been minimized.

Copy link
Member Author

commented Jul 8, 2019

@0xGabi Having that flag would be useful too, although if it prompts users by default, I think that's fine as well.

@0xGabi

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

Oh ok, I thought it might break the CI. But I just realize that all checks have pass 😅

Will revert last commit then.

@sohkai

This comment has been minimized.

Copy link
Member Author

commented Jul 9, 2019

Ah, we don't publish from the CI 😄

@0xGabi 0xGabi force-pushed the apm-prepublish branch from a10ef23 to a0ee042 Jul 9, 2019

@0xGabi

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

@sohkai Ready 👍

@sohkai sohkai merged commit 87d6177 into master Jul 16, 2019

5 of 6 checks passed

coverage/coveralls Coverage decreased (-0.2%) to 98.259%
Details
License Compliance All checks passed.
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@sohkai sohkai deleted the apm-prepublish branch Jul 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.