Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Survey: Add sample survey kit #915

Open
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@facuspagnuolo
Copy link
Contributor

commented Jul 10, 2019

Moving the survey kit from https://github.com/aragon/dao-kits as a sample of the Survey app (similar to what we have for Payroll)

@facuspagnuolo facuspagnuolo requested a review from sohkai Jul 10, 2019

@facuspagnuolo facuspagnuolo self-assigned this Jul 10, 2019

@facuspagnuolo

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

@sohkai should we carry the changes of aragon/dao-kits#63 as well?

@sohkai

This comment has been minimized.

Copy link
Member

commented Jul 10, 2019

@facuspagnuolo We will also need the deploy scripts (ideally in an accessible manner from the npm scripts) so aragen can easily deploy the kit again.

@facuspagnuolo facuspagnuolo referenced this pull request Jul 10, 2019

Closed

SurveyKit: modernize #63

0 of 1 task complete
@facuspagnuolo

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

@sohkai done!

@coveralls

This comment has been minimized.

Copy link

commented Jul 10, 2019

Coverage Status

Coverage decreased (-0.2%) to 97.555% when pulling 8ff650c on add_survey_kit into efa101d on master.

@coveralls

This comment has been minimized.

Copy link

commented Jul 10, 2019

Coverage Status

Coverage decreased (-0.7%) to 97.015% when pulling 9b32d5b on add_survey_kit into efa101d on master.

"publish:kit:rinkeby": "aragon apm publish major $(npm run deploy:kit:rinkeby | tail -n 1) --environment rinkeby",
"deploy:kit:rinkeby": "aragon contracts compile --all && ENS=0x98Df287B6C145399Aaa709692c8D308357bC085D aragon contracts exec --network rinkeby scripts/ deploy.js",
"publish:kit:mainnet": "aragon apm publish major $(npm run deploy:kit:mainnet | tail -n 1) --environment mainnet",
"deploy:kit:mainnet": "aragon contracts compile --all && ENS=0x314159265dd8dbb310642f98f50c066173c1259b aragon contracts exec --network mainnet scripts/ deploy.js"

This comment has been minimized.

Copy link
@sohkai

sohkai Jul 11, 2019

Member

It would be nice to not have most of these npm scripts, since the example kit is unlikely to be published very many times by us.

cc @0xGabi which scripts does aragen depend on?

This comment has been minimized.

Copy link
@facuspagnuolo

facuspagnuolo Jul 11, 2019

Author Contributor

Sure, I honestly don't know how they are used and if they are used in a certain way actually. I migrated all the scripts related stuff that was in the survey kit repo. Let me know if I should remove those

This comment has been minimized.

Copy link
@0xGabi

0xGabi Jul 11, 2019

Member

aragen is only using the publish:kit:rpc and deploy:kit:rpc but I believe it would be posible to use aragonCLI directly in the bash file (here)

My only unknown is how to reference the different template deploy scripts, I believe something like $SCRIPT_NAME.

This comment has been minimized.

Copy link
@sohkai

sohkai Jul 11, 2019

Member

My only unknown is how to reference the different template deploy scripts, I believe something like $SCRIPT_NAME.

Hmm, do you mean which script aragen would use? Perhaps we can standardize on a deploy_kit.js or something that will be used by aragen?

This comment has been minimized.

Copy link
@0xGabi

0xGabi Jul 11, 2019

Member

Yes exactly. You are right, we should standardize. Will check if that's possible with current deploy_kit.js

@sohkai
Copy link
Member

left a comment

👍 👍 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.